Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #1553

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Tests #1553

merged 4 commits into from
Nov 19, 2020

Conversation

NeoTheThird
Copy link
Member

This replaces mocha+sinon+chai+sinonChai+coverage with jest for better electron testing and adds some basic unit tests. Code coverage is abysmal, naturally, but this is only just the beginning.

@codecov-io
Copy link

Codecov Report

Merging #1553 (8f0e40f) into master (24050ee) will decrease coverage by 71.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1553       +/-   ##
===========================================
- Coverage   97.24%   25.57%   -71.68%     
===========================================
  Files           2       14       +12     
  Lines         218      657      +439     
===========================================
- Hits          212      168       -44     
- Misses          6      489      +483     
Impacted Files Coverage Δ
src/lib/asarLibs.js 100.00% <ø> (ø)
src/lib/cache.js 54.54% <0.00%> (-35.11%) ⬇️
src/lib/log.js 100.00% <0.00%> (ø)
src/report.js 22.22% <0.00%> (ø)
src/lib/deviceTools.js 55.55% <0.00%> (ø)
src/lib/updater.js 38.88% <0.00%> (ø)
src/main.js 25.00% <0.00%> (ø)
src/lib/system-image.js 17.14% <0.00%> (ø)
src/lib/errors.js 45.45% <0.00%> (ø)
src/lib/settings.js 75.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24050ee...8f0e40f. Read the comment docs.

@NeoTheThird NeoTheThird marked this pull request as ready for review November 18, 2020 15:59
@NeoTheThird NeoTheThird mentioned this pull request Nov 18, 2020
@NeoTheThird NeoTheThird merged commit 316940a into master Nov 19, 2020
@NeoTheThird NeoTheThird deleted the tests branch November 19, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants