Delay activation of manual device select button #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartinz
reviewed
Apr 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #2611 +/- ##
=======================================
Coverage 76.20% 76.20%
=======================================
Files 29 29
Lines 954 954
=======================================
Hits 727 727
Misses 227 227 Continue to review full report at Codecov.
|
When the app first starts up there can be a slight delay before the configuration files have been downloaded and adb starts up. During this time, if the "Select device manually" button is pressed by the user, the device selection combobox will be empty, which can be confusing for the user. This change disables the button until initialisation is complete, displaying a "Loading device list..." message in the meantime.
llewelld
force-pushed
the
select-device-button
branch
from
88737aa
to
226da13
Compare
maciek134
approved these changes
Apr 26, 2022
NeoTheThird
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the app first starts up there can be a slight delay before the
configuration files have been downloaded and adb starts up.
During this time, if the "Select device manually" button is pressed by
the user, the device selection combobox will be empty, which can be
confusing for the user.
This change disables the button until initialisation is complete,
displaying a "Loading device list..." message in the meantime.