lib: updater: fix semver comparison #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flohack74
previously approved these changes
Apr 20, 2023
maciek134
force-pushed
the
fix/version-comparison
branch
2 times, most recently
from
5981211
to
0784ffa
Compare
Signed-off-by: Maciej Sopylo <me@klh.io>
maciek134
force-pushed
the
fix/version-comparison
branch
from
0784ffa
to
35b7168
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3238 +/- ##
==========================================
+ Coverage 84.05% 84.08% +0.02%
==========================================
Files 32 32
Lines 1085 1087 +2
==========================================
+ Hits 912 914 +2
Misses 173 173
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Flohack74
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the comparison in updater to be semver-compatible.
I'd recommend bumping the version to
0.10.0to make versions0.9.2-0.9.9show the update prompt.Keep in mind that in semver
0.0.1is more recent than0.0.1-beta- and we should make sure thepackage.jsonversion is in sync with the tag names, it will always scream for an update if it's a0.10.0tag and0.10.0-betainpackage.json