Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

Depends on systemd #8

Closed
z3ntu opened this issue Oct 25, 2018 · 4 comments
Closed

Depends on systemd #8

z3ntu opened this issue Oct 25, 2018 · 4 comments

Comments

@z3ntu
Copy link
Contributor

z3ntu commented Oct 25, 2018

For postmarketOS we will need a separate implementation for libubuntu-app-launch/jobs-systemd.{cpp,h}

@ollieparanoid
Copy link

There are various branches in this repo, and some don't have the jobs-systemd.cpp files. Can't we use another branch, or revert the patch that introduced these files?

@z3ntu
Copy link
Contributor Author

z3ntu commented Oct 28, 2018

The xenial branch depends on libupstart (the init system old Ubuntus used), so something has to be done anyways.

@ollieparanoid
Copy link

I see. At least it seems that support for multiple job backends was thought of here:

/** Should determine which jobs backend to use, but we only have
one right now. */
std::shared_ptr<Base> Base::determineFactory(const std::shared_ptr<Registry::Impl>& registry)
{
g_debug("Building a systemd jobs manager");
return std::make_shared<jobs::manager::SystemD>(registry);
}

So we would need a libubuntu-app-launch/jobs-openrc.cpp, right?

How about we start by copying jobs-systemd.cpp, rename "SystemD" to "OpenRC" and stub out everything (do nothing except log a message), except for starting new applications for a proof of concept?

CC: @NotKit

@UniversalSuperBox
Copy link
Member

ubuntu-app-launch has been renamed to lomiri-app-launch and moved to https://gitlab.com/ubports/core/lomiri-app-launch. Unfortunately, I don't think this issue has been solved yet. Please let us know by creating a new issue on the new repository. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants