Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Create 16.04 framework #4

Merged
merged 1 commit into from Feb 25, 2018
Merged

Create 16.04 framework #4

merged 1 commit into from Feb 25, 2018

Conversation

mariogrip
Copy link
Member

No description provided.

Copy link
Contributor

@dpniel dpniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Keeping the current naming convention keeps it simple as well, as it won't break click-review etc

@NeoTheThird
Copy link
Member

We'll have to update click-review though, right?

@sverzegnassi
Copy link

@NeoTheThird Apparently, it would still break click-review, since framework policies needs to be manually updated in click-review.
Ref. http://bazaar.launchpad.net/~store-reviewers/click-reviewers-tools/trunk/view/head:/clickreviews/cr_security.py#L129

WARNING:root:Ignoring missing framework "ubuntu-sdk-16.04"
Now executing: click-review ./submitnewapp.milkor73_1.1.0_all.click
Errors
------
 - lint:framework
	'ubuntu-sdk-16.04' is not a supported framework
	http://askubuntu.com/questions/460512/what-framework-should-i-use-in-my-manifest-file
 - security:policy_version_matches_framework:app.json
	Invalid framework 'ubuntu-sdk-16.04'
	http://askubuntu.com/q/562116/94326
./submitnewapp.milkor73_1.1.0_all.click: FAIL
Successfully built package in './submitnewapp.milkor73_1.1.0_all.click'.

@mariogrip mariogrip merged commit 0c555da into xenial Feb 25, 2018
@mariogrip mariogrip deleted the xenial-dev branch February 25, 2018 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants