Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove htop #40

Merged
merged 1 commit into from Apr 3, 2019

Conversation

@NeoTheThird
Copy link
Member

commented Apr 1, 2019

We added htop to the image on a whim when preparing for (i think) ota-3. In hindsight, i'm not sure that was the best idea, and there are a couple of reasons for that. For one, most users don't need it on a regular basis, and those who do are likely power users who could just as well install the deb package or use this. But the main reason i'm filing this pr is because it resolves (or rather avoids the issue, i'll look into actually resolving it later) half of ubports/ubuntu-touch#1065 and also helps a teensy little bit with ubports/ubuntu-touch#1078.

Requesting review from the people who i think were part of the decision to include it back in the day. What do you think, is this stupid, or should we maybe even go even farther and look for more nonessential stuff we can remove?

@Flohack74
Copy link
Member

left a comment

I think its good to remove it. htop is a nice tool, but its truly optional. We might add it to a list of things to install later on request. But why the heck it sports a desktop file?

@UniversalSuperBox
Copy link
Member

left a comment

Further complicates ubports/ubuntu-touch#888, but we need all the space (and launcher bugfixing) we can get

@Flohack74 Flohack74 merged commit 97a9700 into xenial_-_edge Apr 3, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@Flohack74 Flohack74 deleted the xenial_-_edge_-_no-htop branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.