This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Remove htop #40
Merged
Remove htop #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flohack74
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Further complicates ubports/ubuntu-touch#888, but we need all the space (and launcher bugfixing) we can get
UniversalSuperBox
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added htop to the image on a whim when preparing for (i think) ota-3. In hindsight, i'm not sure that was the best idea, and there are a couple of reasons for that. For one, most users don't need it on a regular basis, and those who do are likely power users who could just as well install the deb package or use this. But the main reason i'm filing this pr is because it resolves (or rather avoids the issue, i'll look into actually resolving it later) half of ubports/ubuntu-touch#1065 and also helps a teensy little bit with ubports/ubuntu-touch#1078.
Requesting review from the people who i think were part of the decision to include it back in the day. What do you think, is this stupid, or should we maybe even go even farther and look for more nonessential stuff we can remove?