Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Wizard: Should automatically advance after network connection #845

Closed
bhdouglass opened this Issue Sep 1, 2018 · 7 comments

Comments

Projects
6 participants
@bhdouglass
Copy link
Member

bhdouglass commented Sep 1, 2018

When selecting a wifi network in the welcome wizard it would be nice if it automatically advanced to the next page after a network connection is made.

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Oct 5, 2018

This issue should be fairly easy to fix if you have an Ubuntu Touch device. Even if you don't and have some QML know-how, you can get through this.

Check out 30-wifi.qml in Unity8. The QML has a property called connected. Every time this changes, it will fire a signal (connectedChanged). You can create a handler for this signal (onConnectedChanged: {}) which checks if connected is true, then calls pageStack.next() if it is.

You can edit this QML directly on your device if you want. Mount the rootfs read-write and then edit the file (I think it's in /usr/share/unity8/Wizard/Pages/). To run through the wizard, run rm .config/ubuntu-system-settings/wizard-has-run and then restart unity8. You will need to forget your Wi-Fi network before doing that to see the Wi-Fi page!

If you're taking this on, please add a comment here to say so.

@dark-eye

This comment has been minimized.

Copy link

dark-eye commented Oct 11, 2018

@UniversalSuperBox Can i take this? i have little time lately... :/

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Oct 11, 2018

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Jan 21, 2019

@dark-eye are you still interested in this, or shall we wait for another contributor to give it a shot? :)

@Arc676

This comment has been minimized.

Copy link

Arc676 commented Jan 22, 2019

I can confirm that the fix suggested by @UniversalSuperBox works as expected on Nexus 5 running devel 16.04 (2019-01-11).

Added these lines to /usr/share/unity8/Wizard/Pages/30-wifi.qml:

    onConnectedChanged: {
        if (connected) {
            pageStack.next()
        }
    }

Notes: the wizard appeared immediately, even without restarting Unity 8. Also, there was significant latency after the wizard exited, possibly because the device was actually already set up.

@Arc676

This comment has been minimized.

Copy link

Arc676 commented Jan 23, 2019

@UniversalSuperBox Since you already knew how to fix this in October of last year, why didn't you? I'd be happy to make the edits mentioned in my last comment in the Unity 8 repository, but the fact that it's 5 lines and you didn't already do this suggests that there's more to this that I'm aware of.

I should add that I have no experience working on operating system components.

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Jan 24, 2019

We want to drag in more people into development with easy tasks. When we solve all easy tasks by ourselves, how we can ever grow, since people have no starting point. So yes, patches welcome ;) - And strictly spoken its not a real OS component but rather part of the display environment unity8, so you cannot break that much ;)

Arc676 added a commit to Arc676/unity8 that referenced this issue Jan 24, 2019

UniversalSuperBox added a commit to ubports/unity8 that referenced this issue Mar 29, 2019

Automatically advance setup wizard on WiFi connection (#92)
Employs the fix suggested by @UniversalSuperBox to automatically advance the setup wizard once a connection to a WiFi network is established.

Closes ubports/ubuntu-touch#845.

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-9 via automation Mar 29, 2019

@UniversalSuperBox UniversalSuperBox moved this from To do to QA in OTA-9 Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.