New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Wizard: Should automatically advance after hitting enter #846

Closed
bhdouglass opened this Issue Sep 1, 2018 · 11 comments

Comments

Projects
7 participants
@bhdouglass
Copy link
Member

bhdouglass commented Sep 1, 2018

When entering the "Preferred Name" into the welcome wizard, if the user hits the enter button it would be nice if it advanced to the next page automatically. Currently hitting the enter button just closes the keyboard. This also happens when inputting a password.

@bhdouglass bhdouglass changed the title Welcome Wizard: Should automatically advance after inputting name Welcome Wizard: Should automatically advance after hitting enter Sep 1, 2018

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Oct 5, 2018

This issue should be fairly easy to fix if you have an Ubuntu Touch device. Even if you don't and have some QML know-how, you can get through this.

Check out 60-account.qml in Unity8. The textField where you enter your username has an accepted signal which is fired when the user presses Return on their keyboard. Hook that signal (onAccepted:) up to the next() signal on the pageStack to complete this task.

You can edit this QML directly on your device if you want. Mount the rootfs read-write and then edit the file (I think it's in /usr/share/unity8/Wizard/Pages/). To run through the wizard, run rm .config/ubuntu-system-settings/wizard-has-run and then restart unity8.

If you're taking this on, please add a comment here to say so.

@nikalon

This comment has been minimized.

Copy link

nikalon commented Oct 13, 2018

Would you mind if I take this? This will give me an excuse to start hacking on Ubuntu Touch :D

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Oct 13, 2018

Of course! Just let me know if you have any questions

@nikalon

This comment has been minimized.

Copy link

nikalon commented Oct 14, 2018

I don't know if I should link here but here's the PR: ubports/unity8#79

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Oct 15, 2018

Fixed by ubports/unity8#79

Thanks @nikalon!

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-6 QA Tracker via automation Nov 23, 2018

@UniversalSuperBox UniversalSuperBox added this to the 16.04 OTA-6 milestone Nov 23, 2018

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Nov 26, 2018

Note for QA:

You can re-run the Welcome Wizard once per session (reboot) by running truncate -s 0 .config/ubuntu-system-settings/wizard-has-run in the device terminal or via adb shell.

@3arn0wl

This comment has been minimized.

Copy link

3arn0wl commented Nov 27, 2018

:) Hey! Thanks for this. Is there a way to run the code which tells us about swiping?

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Nov 28, 2018

Sorry, I had the wrong command. rm .config/ubuntu-system-settings/wizard-has-run runs the wizard which is used in this case.

@3arn0wl, I'm not sure how to re-run the tutorial.

@3arn0wl

This comment has been minimized.

Copy link

3arn0wl commented Nov 28, 2018

Thanks Dalton. :)

@cibersheep

This comment has been minimized.

Copy link

cibersheep commented Nov 29, 2018

This is fixed in 2018-W48 on m10 HD
I get the menu until the welcome but tapping on introduction takes a long time and closes the wizard.

@UniversalSuperBox UniversalSuperBox moved this from To do to Accepted in OTA-6 QA Tracker Nov 30, 2018

@hsbyter

This comment has been minimized.

Copy link

hsbyter commented Dec 2, 2018

Fixed in 2018-w48 on m10 FHD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment