Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main action arranged on the right and Cancel now has a neutral color #33

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@StefWe
Copy link
Contributor

commented Apr 17, 2019

@cibersheep has pointed out to me that the arrangement and color of the buttons here does not correspond to the standard.

About the buttons, have in mind that we usually:

  • color the main action (red if it's destructive, green if positive) but avoid coloring both.
  • Make clear message of what the action is doing. So, instead of Fertig, I would say Scale. Abbrechen is good :)
  • Main action goes to the right (or top) so I suggest: [neutral color Abbrechen] [green color Scale] order

So i made some small changes
Before
56136418-0d54c000-5f93-11e9-8fbe-ac060118c556
Now
screenshot20190417_094615714_edit

@Flohack74 Flohack74 merged commit 0ccb6a3 into ubports:xenial Apr 17, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.