Replace use of assert_not_called in the catkin tests
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocks using `assert_not_called` don't take a message, to keep the message we use `assertFalse` and the `called` attribute of the mock.
|
Thanks @sergiusens! Looks great. I'll just wait for Travis to finish. |
kyrofa
pushed a commit
that referenced
this pull request
Jan 5, 2016
Replace use of `assert_not_called` in the catkin tests
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
Separate provision agent and guest agent
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Replace use of `assert_not_called` in the catkin tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocks using
assert_not_calleddon't take a message, to keep the messagewe use
assertFalseand thecalledattribute of the mock.