interfaces: allow unity7 launcher API #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 12, 2016 16:43
…reoffice)
The gmenu DBus api was not designed for application isolation and apps may
specify anything as their 'path'. For example, these work in the many cases:
- /org/gtk/Application/anonymous{,/**}
- /com/canonical/unity/gtk/window/[0-9]*
but libreoffice does:
- /org/libreoffice{,/**}
As such, we cannot mediate by DBus path so be as strict as we can in the other
mediated parts.
|
+1 I wonder if there's a way to generate some of those rules and definitions. It certainly would be nicer if we could just cross-check this with some API docs. |
|
👍 |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.