skills: add basic grant-revoke methods #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the four basic grant / revoke methods: Repository.Grant() grants a skill to a slot. Repository.Revoke() revokes an existing grant. Repository.GrantedTo() returns information about all skills granted to particular slots in a given snap. Repository.GrantedBy() returns information about all skills, from a particular snap, granted to various slots in various snaps. There are several related internal changes. Removing used skills or occupied slots is no longer allowed and now returns an error. Internally tests were tweaked to ensure that test skill and test slot don't belong to the same snap. This helps in making asymmetric tests for granted-to vs granted-by easier to follow. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
| skills map[string]map[string]*Skill | ||
| slots map[string]map[string]*Slot | ||
| skillUsedBySlot map[*Slot]map[*Skill]bool | ||
| slotsUsingSkill map[*Skill]map[*Slot]bool |
There was a problem hiding this comment.
skillUsedBySlot => slotSkills
slotsUsingSkill => skillSlots
|
LGTM once you're happy about these points. |
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
|
Refreshed, please have a 2nd look. |
|
👍 |
zyga
added a commit
that referenced
this pull request
Feb 1, 2016
skills: add basic grant-revoke methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the four basic grant / revoke methods
Repository.Grant() grants a skill to a slot.
Repository.Revoke() revokes an existing grant.
Repository.GrantedTo() returns information about all skills granted to particular slots in a given snap.
Repository.GrantedBy() returns information about all skills, from a particular snap, granted to various slots in various snaps.
There are several related internal changes. Removing used skills or
occupied slots is no longer allowed and now returns an error.
Internally tests were tweaked to ensure that test skill and test slot
don't belong to the same snap. This helps in making asymmetric tests for
granted-to vs granted-by easier to follow.