snappy: rename "migration-skill" to "old-security" and use new interface names instead of skills #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergiusens breakage is coming. |
| Most of the security aspects of the system will be done via skills and | ||
| skill slots. However for compatibility with the 15.04 snappy | ||
| architecture there is a special skill type called `migration-skill` | ||
| Most of the security aspects of the system will be done via interfaces and |
There was a problem hiding this comment.
replace the first and with a comma.
|
Does this really have more prio than getting the kernel snaps in place? |
|
+1 |
| if len(app.UsesRef) != 1 { | ||
| return nil, fmt.Errorf("only a single skill is supported, %d found", len(app.UsesRef)) | ||
| if len(app.SlotsRef) != 1 { | ||
| return nil, fmt.Errorf("only a single skill is supported, %d found", len(app.SlotsRef)) |
|
LGTM, just a few more occurrences to replace. @sergiusens This is really not the place (or the tone) for that kind of conversation. |
|
@niemeyer thanks for this excellent review and sorry for overlooking these. I did a |
|
retest this please |
mvo5
added a commit
that referenced
this pull request
Mar 1, 2016
snappy: rename "migration-skill" to "old-security" and use new interface names instead of skills
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch follows thenew
interfacesapproach and renames the following items:It is pretty mechanical. Note that the integration tests will start failing. I will prepare new versions of all our examples so ideally we only merge once the new examples are uploaded.