Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty gpu error #299

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Fix empty gpu error #299

merged 1 commit into from
Mar 8, 2022

Conversation

Jupi007
Copy link
Collaborator

@Jupi007 Jupi007 commented Mar 8, 2022

Add No GPU info found label when no gpu are in the list returned by GpuInfo.
This fix the exception throw when trying to access to the first element of the empty array.

@Feichtmeier Can you test this to see if it works as expected? I don't have a Flutter ready VM available.

Closes #297

@Jupi007 Jupi007 requested a review from Feichtmeier March 8, 2022 10:30
@Feichtmeier
Copy link
Member

The error is gone
image

Maybe here or in another PR we could try to get the same info as GCC for virtual machines

image

@Jupi007
Copy link
Collaborator Author

Jupi007 commented Mar 8, 2022

Maybe here or in another PR we could try to get the same info as GCC for virtual machines

This require to modify the library, but honestly it is outside of my skill range 😅

@Jupi007 Jupi007 merged commit 9922865 into master Mar 8, 2022
@Jupi007 Jupi007 deleted the InfoPage_fix_no_gpu_info branch March 8, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfoPage: skip gpu info if not available
2 participants