[WIP] Restrict ReplayKeyboard events to application mappeable shortcuts #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keycode is properly mappeable to application-level shortcuts. This prevents strange key combinations to be replayed, including ones like Alt+Tab. We determine which keycodes are valid based on whether they are both shift-able and alt-able. This effectively rules out most function and control keys, which should be only allows asynchronously.
|
Fixes #16 ... maybe! |
vkareh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine when to allow Replay versus Async events based on whether the keycode is properly mappeable to application-level shortcuts. This prevents strange key combinations to be replayed, including ones like Alt+Tab.
We determine which keycodes are valid based on whether they are both shift-able and alt-able. This effectively rules out most function and control keys, which should be only allows asynchronously.