Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept #1

Closed
wants to merge 1 commit into from
Closed

Proof of concept #1

wants to merge 1 commit into from

Conversation

jpnurmi
Copy link

@jpnurmi jpnurmi commented Feb 23, 2022

There's some brokenness here and there, mostly issues with assets, but this is a good starting point... :)

Screenshot from 2022-02-23 18-08-21
Screenshot from 2022-02-23 18-08-26
Screenshot from 2022-02-23 18-08-30
Screenshot from 2022-02-23 18-08-34
Screenshot from 2022-02-23 18-08-38
Screenshot from 2022-02-23 18-09-06
Screenshot from 2022-02-23 18-09-10
Screenshot from 2022-02-23 18-09-15
Screenshot from 2022-02-23 18-09-47
Screenshot from 2022-02-23 18-30-47
Screenshot from 2022-02-23 18-09-57

@jpnurmi
Copy link
Author

jpnurmi commented Feb 23, 2022

I've opened canonical/ubuntu-desktop-installer#700 for tracking the issues found so far. This project will help us to catch this type of issues earlier. 👍

There's some brokenness here and there, mostly issues with assets,
but this is a good starting point... :)

It would have been nice to have ubuntu_desktop_installer fetched
straight from Git but pub doesn't like it because udi has some local
dependencies such as "glibc: path: ../glibc". Unfortunately, even
dependency_overrides doesn't help in this case:

    "glibc" dependency: "../glibc" is a relative path, but this isn't a local pubspec.

Therefore, a Git submodule is used instead.
@jpnurmi jpnurmi marked this pull request as draft February 24, 2022 07:52
@jpnurmi
Copy link
Author

jpnurmi commented Feb 24, 2022

I'll investigate another way to import the installer & subiquity dependencies.

@ymauray
Copy link

ymauray commented Feb 24, 2022

Hi ! I am so excited about this ! Let me know if you need any help with that on the Ubuntu MATE side.

jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this pull request Feb 28, 2022
- organize assets into subdirs named after pages to make it clear where
  each asset is used
- use more generic and flavor-friendly asset names that don't assume
  the vanilla asset image content (e.g. "mascot" -> "logo")

Ref: canonical#700
Ref: ubuntu-mate/ubuntu-mate-installer#1
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this pull request Feb 28, 2022
- organize image assets into subdirs named after pages to make it clear
  where each image is used
- use more generic and flavor-friendly asset names that don't assume
  the content (e.g. "mascot" -> "logo") of the vanilla image assets

Ref: canonical#700
Ref: ubuntu-mate/ubuntu-mate-installer#1
jpnurmi added a commit to canonical/ubuntu-desktop-installer that referenced this pull request Mar 3, 2022
- organize image assets into subdirs named after pages to make it clear
  where each image is used
- use more generic and flavor-friendly asset names that don't assume
  the content (e.g. "mascot" -> "logo") of the vanilla image assets

Ref: #700
Ref: ubuntu-mate/ubuntu-mate-installer#1
@flexiondotorg
Copy link
Member

@jpnurmi Can this be merged yet? How do we proceed with testing the new installer in Ubuntu MATE?

@jpnurmi
Copy link
Author

jpnurmi commented Mar 16, 2022

My apologies that this is taking so long. I'm still waiting for a few ubuntu-desktop-installer changes to land, and then I'll be able to finish this.

Finally, after #727, we'll replace ubuntu-desktop-installer's subiquity submodule with a subtree. This will greatly simplify things because there won't be a need for any submodule or subtree in this repo.

@jpnurmi jpnurmi closed this by deleting the head repository Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants