Update readme for Java 17 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpa1977
force-pushed
the
update-report-for-17
branch
from
02eb575
to
bdecd80
Compare
Signed-off-by: Vladimir Petko <vladimir.petko@canonical.com>
cjdcordeiro
requested changes
Jun 23, 2023
There was a problem hiding this comment.
Thanks for this ;)
I've left a few nitpicks.
Some of the text is also still pointing to the old chiselled-jre folder and image references, so that should be updated.
I'm also adding @valentincanonical to the list of reviewers as I believe this is useful to him.
Co-authored-by: Cristovao Cordeiro <cristovao.cordeiro@canonical.com> Signed-off-by: Vladimir Petko <vladimir.petko@canonical.com>
Co-authored-by: Cristovao Cordeiro <cristovao.cordeiro@canonical.com> Signed-off-by: Vladimir Petko <vladimir.petko@canonical.com>
Co-authored-by: Cristovao Cordeiro <cristovao.cordeiro@canonical.com> Signed-off-by: Vladimir Petko <vladimir.petko@canonical.com>
- capitalized Temurin - ubuntu/chiselled_jre -> ubuntu/jre - fixed article usage Signed-off-by: Vladimir Petko <vladimir.petko@canonical.com>
Signed-off-by: Vladimir Petko <vladimir.petko@canonical.com>
Signed-off-by: Vladimir Petko <vladimir.petko@canonical.com>
cjdcordeiro
approved these changes
Jun 26, 2023
|
reminder (@valentincanonical) |
|
@valentincanonical I'm merging this since it has been in review for a long time. please open an issue if you find anything that needs changing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Update readme for Java 17
[*] I have signed the CLA?
Picture of a cool ROCK: