Enables downloading images from the c-i.u.c/wsl #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only kinetic (22.10) and later are published to that location. Previous versions stay in cloud-images.ubuntu.com/
didrocks
requested changes
Jul 21, 2022
| @@ -34,7 +35,14 @@ func buildGHMatrix(csvPath, metaPath string) error { | |||
| if i == 0 { | |||
| t = "" | |||
| } | |||
| t += fmt.Sprintf("https://cloud-images.ubuntu.com/%s/current/%s-server-cloudimg-%s-wsl.rootfs.tar.gz::%s", r.CodeName, r.CodeName, arch, arch) | |||
| // Currently only Kinetic (22.10) and later are published to "https://cloud-images.ubuntu.com/wsl/" | |||
| codeNameSubUri := func() string { | |||
There was a problem hiding this comment.
hum, it seems a little bit complicated when you can write it that way:
codeNameSubUri := r.CodeName
if strings.Compare(r.BuildVersion, "2210") >= 0 {
codeNameSubUri = filepath.Join("wsl", r.CodeName)
}There was a problem hiding this comment.
You got it right. Thanks for the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Go skills are a bit rusty, so I'd prefer asking review from an expert. 馃槃
Per the CPC team information. Kinetic (22.10) and later versions are to be published to that location (see https://cloud-images.ubuntu.com/wsl/kinetic/ for instance). Previous versions stay in cloud-images.ubuntu.com.
This PR aims to let the build matrix routine to differentiate the base URI from where to download the images.