Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strings.Fields to split the checksum file. #241

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

CarlosNihelton
Copy link
Collaborator

@CarlosNihelton CarlosNihelton commented Jul 25, 2022

The WSL pipeline checksum file has more whistespaces between the fields.
strings.Split fails to produce the desired output: Split: ["2f1e68d12994cb9c61085ea09720c7cef1728ca634ba9a447baa8a295499daf8" "" "ubuntu-kinetic-wsl-amd64-wsl.rootfs.manifest"]
strings.Fields can treat multiple whitespaces as one, thus generating the expected length-2 slices.

The WSL pipeline checksum file has more whistespaces between the fields.
strings.split fails to produce the desired output.
strings.Fields can treat multiple whitespaces as one.
@CarlosNihelton CarlosNihelton marked this pull request as ready for review July 25, 2022 11:02
Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn’t know about that in stdlib, I have some code to update… :p

@CarlosNihelton CarlosNihelton merged commit 3340751 into main Jul 27, 2022
@CarlosNihelton CarlosNihelton deleted the fix-build-wsl-kinetic branch July 27, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants