Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding e2e testing relating to config #292

Merged
merged 16 commits into from Oct 17, 2022
Merged

Conversation

EduardGomezEscandell
Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell commented Oct 10, 2022

The launcher modifies some config files in WSL. These tests verify this happens.

Feature commits:

  • 96dc60f tests that systemd is enabled and that the fixes the launcher applies to to sysusers service work.
  • 8acfd93 tests that the upgrade policy is set according to the distro name
  • 5f1d754 tests that we used the right rootfs link. This test will have to be updated every time there is new release. I didn't want to automate it because the point of this test is to test this very automation.

Cleanup commits:

  • 7cf259e. This commit is best viewed without whitespace diffs. I enclosed each set of assertions in their own scope to avoid bleeding variables from one test to the next one. This commit makes big enough changes that merging the latter cleanup commits with the previous ones is too much of a hassle.

Later commits are bugfixes and smaller changes.

* This avoids reusing variables between tests, to provide better isolation
* Also makes commenting out tests for debugging easier
* The assertion would fail when it encountered status "starting"
* Now it loops in one-second increments when it finds this status
Copy link
Collaborator

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have room for improvement here.

e2e/test-runner/go.mod Outdated Show resolved Hide resolved
e2e/test-runner/runner_test.go Outdated Show resolved Hide resolved
e2e/test-runner/runner_test.go Outdated Show resolved Hide resolved
e2e/test-runner/runner_test.go Outdated Show resolved Hide resolved
e2e/test-runner/runner_test.go Outdated Show resolved Hide resolved
e2e/test-runner/runner_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Great job with the function split-up! It looks gorgeous!

@EduardGomezEscandell EduardGomezEscandell merged commit c58ffb4 into main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants