Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aad auth various fixes #60

Merged
merged 6 commits into from Sep 6, 2022
Merged

Aad auth various fixes #60

merged 6 commits into from Sep 6, 2022

Conversation

jibel
Copy link
Collaborator

@jibel jibel commented Sep 6, 2022

Various fixes:

  • Do not print a \n when listing entries to prevent crash
  • Initialize shadow flags
  • Renamed aad_auth to aad-auth
  • Moved string function after New() functions

jibel and others added 3 commits September 6, 2022 10:43
@jibel @didrocks
Do not print an empty line when printing entries
e43ecb2 
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
@jibel @didrocks
Initialize shadow flags
b6421a7 
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
@jibel @didrocks
Move string function after New functions
2645b99 
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
@jibel jibel requested a review from a team as a code owner September 6, 2022 08:49
jibel and others added 3 commits September 6, 2022 10:51
@jibel @didrocks
Renamed aad_auth to aad-auth
dfb5d60 
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
@jibel @didrocks
Update golden files
0d870a3 
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
@jibel @didrocks
Update golden files for expected formatting by the lib.
f24ee25 
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
@didrocks
Copy link
Member

didrocks commented Sep 6, 2022

Ok, tests are now updated and we can log in. @denisonbarbosa FYI.

@didrocks didrocks merged commit 5e81277 into main Sep 6, 2022
@didrocks didrocks deleted the aad-auth_various_fixes branch September 6, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jibel @didrocks