Fix chown scripts #287
Merged
Fix chown scripts #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didrocks
force-pushed
the
fix_chown_scripts
branch
from
72eb0cd
to
9eaee68
Compare
Only chown to uid and gid when creating directories and any fd before closing we are in control of. This impacted the API for passing desired uid and gid. Remove the final recursive reset. Adapt tests to it.
didrocks
force-pushed
the
fix_chown_scripts
branch
from
9eaee68
to
1f7ca60
Compare
didrocks
force-pushed
the
fix_chown_scripts
branch
from
1f7ca60
to
27629d1
Compare
Adapt tests to it.
didrocks
force-pushed
the
fix_chown_scripts
branch
from
27629d1
to
8b38835
Compare
|
Nice fix indeed :) thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix potential security race with user/gid reset
Only chown to uid and gid when creating directories and any fd before closing we are in control of.
This impacted the API for passing desired uid and gid.
Remove the final recursive reset.
Rework chowning when needed. Set -1 to be API compliant for no change.