Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround tests hanging on ppcel64 #295

Merged
merged 1 commit into from Mar 8, 2022
Merged

Conversation

didrocks
Copy link
Member

@didrocks didrocks commented Mar 8, 2022

When killing smbd process, on ppcel64, stderr was not closed, causing
the tests to hang forever.

When killing smbd process, on ppcel64, stderr was not closed, causing
the tests to hang forever.
@codecov-commenter
Copy link

Codecov Report

Merging #295 (3973c14) into main (20e6f96) will increase coverage by 0.02%.
The diff coverage is 57.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   84.78%   84.80%   +0.02%     
==========================================
  Files          56       56              
  Lines        3891     3897       +6     
==========================================
+ Hits         3299     3305       +6     
+ Misses        373      372       -1     
- Partials      219      220       +1     
Impacted Files Coverage Δ
internal/policies/scripts/scripts.go 83.21% <45.00%> (+0.78%) ⬆️
internal/policies/policies.go 79.27% <76.92%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652018d...3973c14. Read the comment docs.

@didrocks didrocks requested a review from jibel March 8, 2022 09:37
Copy link
Collaborator

@jibel jibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@jibel jibel merged commit aadb62e into main Mar 8, 2022
@jibel jibel deleted the workaround-ppcel64-smbd-hang branch March 8, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants