refactor: Migrate away snap model from old provider style

[spydon]

This migrates away from the custom ChangeNotifierProvider approach.

It also makes sure that futures aren't completed until the polling of the changeId has returned which makes the the structure slightly cleaner.

Things that are left to consider:

• Whether the snap operations should be happening within a model instead of in separate providers like they do now.
• How to handle actions from buttons.

With a refactor this big I'm sure that some bugs have been introduced, so make sure to test a lot if you continue working on this!

[d-loose]

Looks like there are some yaru related style changes (background colors of the containers) we need to address:

[d-loose]

Here we're handling the case where the snap isn't locally installed, but it's available in the store (SnapdClient throws an exception when it receives a 4xx status from snapd).

[spydon]

Not a very smooth way of dealing with a 4xx, maybe we should fix that in the snapdclient at some point.

[d-loose]

I think all our dart client libraries for HTTP APIs do it that way at the moment.

In the subiquity client we've got this:

    if (response.statusCode != 200) {
      throw SubiquityException(method, response.statusCode, str);
    }

But if you think it's worth improving this, I'm up for it :)

[d-loose]

Looks like there are some yaru related style changes (background colors of the containers) we need to address:

Maybe until we sort out the yaru.dart issues we can simply force AppCard to use the theme's cardColor

diff --git a/packages/app_center/lib/src/widgets/app_card.dart b/packages/app_center/lib/src/widgets/app_card.dart
index 365bf709..5948faec 100644
--- a/packages/app_center/lib/src/widgets/app_card.dart
+++ b/packages/app_center/lib/src/widgets/app_card.dart
@@ -75,6 +75,7 @@ class AppCard extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return YaruBanner(
+      color: Theme.of(context).cardColor,
       padding: const EdgeInsets.all(kCardSpacing),
       onTap: onTap,
       child: Flex(

P.S. We'd need a corresponding change for the SnapImageCard, which is a separate widget

[spydon]

Looks like there are some yaru related style changes (background colors of the containers) we need to address:

Maybe until we sort out the yaru.dart issues we can simply force AppCard to use the theme's cardColor

diff --git a/packages/app_center/lib/src/widgets/app_card.dart b/packages/app_center/lib/src/widgets/app_card.dart
index 365bf709..5948faec 100644
--- a/packages/app_center/lib/src/widgets/app_card.dart
+++ b/packages/app_center/lib/src/widgets/app_card.dart
@@ -75,6 +75,7 @@ class AppCard extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return YaruBanner(
+      color: Theme.of(context).cardColor,
       padding: const EdgeInsets.all(kCardSpacing),
       onTap: onTap,
       child: Flex(

P.S. We'd need a corresponding change for the SnapImageCard, which is a separate widget

Fixed in 06fe6cf and 79f7dc4

[d-loose]

Just a final nitpick/question, since it came up in the meeting with Innes as well: to me this feels like UI specific code (maybe icons/l10n more than the actions and corresponding callbacks). Should we keep (some of) this in snap_page.dart?

[spydon]

Yeah, I don't remember why I moved it now, it should maybe even get its own file

[spydon]

Done!

[d-loose]

Thanks a lot, I think this is the first big step towards a massive improvement of the overall state management and code structure!