Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert RatingsModel to modern provider style #1703

Closed
spydon opened this issue Jun 17, 2024 · 1 comment
Closed

Convert RatingsModel to modern provider style #1703

spydon opened this issue Jun 17, 2024 · 1 comment
Assignees
@spydon
Labels
enhancement: code 👩‍💻 Code improvements or refactoring jira Sync with JIRA

Comments

@spydon
Copy link
Collaborator

spydon commented Jun 17, 2024

Should be pretty straight forward since the whole structure is now set by #1660, we just need to:

  • Implement generated provider
  • Freezed class to hold the state
  • Migrate methods to generated provider
  • Update how it is used in the UI code
@spydon spydon self-assigned this Jun 17, 2024
@spydon spydon added enhancement: code 👩‍💻 Code improvements or refactoring jira Sync with JIRA labels Jun 17, 2024
@spydon
Copy link
Collaborator Author

spydon commented Jul 2, 2024

This was done in #1705

@spydon spydon closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spydon spydon

Labels
enhancement: code 👩‍💻 Code improvements or refactoring jira Sync with JIRA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spydon