Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use a paned look #1621

Merged
merged 16 commits into from
Jul 1, 2024
Merged

feat: use a paned look #1621

merged 16 commits into from
Jul 1, 2024

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Mar 19, 2024

  • to reduce the number of visual color background areas, use the paned look that can be found in gtk4 apps
  • since the right titlebar then has more contrast against the search field, remove the searchfield fill color override, this also...

Fixes #1612
Fixes #1562

Before After
light grafik grafik
dark grafik grafik

- to reduce the number of visual color background areas, use the paned look that can be found in gtk4 apps
- since the right titlebar then has more contrast against the search field, remove the searchfield fill color override, this also...

Fixes #1612
@Feichtmeier
Copy link
Member Author

CC @anasereijo

@Feichtmeier
Copy link
Member Author

Feichtmeier commented Apr 8, 2024

@anasereijo
If you might be concerned about the whitespace, we could also move certain elements out of the bottom left bar into the appbars at the top
grafik
(example mockup)
I think a fully fletched dedicated menu entry only for "about" is very uncommon anyways
what modern gnome apps often do, is place a hamburger menu in the top left bar if it is a paned application
which then leads to a setting dialog
grafik
grafik
(examples and mockups)

@anasereijo anasereijo added enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed UI/UX labels Apr 22, 2024
@anasereijo
Copy link
Collaborator

@Feichtmeier sorry for the delayed reply. We will be revisiting the App Center next cycle (starting mid May). These are great proposals, and we will be looking at this for sure when we start looking at the store again.

Thanks for your input 🙏

@Feichtmeier Feichtmeier requested review from d-loose and removed request for BLKKKBVSIK June 2, 2024 07:54
@Feichtmeier
Copy link
Member Author

Feichtmeier commented Jun 2, 2024

@anasereijo

Just had another look on this, and I think the settings button is fine in the left panel.

The big improvement (imo) with this change is the visual center. Because now the right pane content and headerbar, including the searchbar, are centered around the same axis

grafik

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, can you open an issue for moving the other things around @Feichtmeier ?
EDIT: I opened #1725

@anasereijo
Copy link
Collaborator

@Feichtmeier changes approved, it looks much better! Thanks for doing this, and apologies for taking a long time to come back to you.

@spydon spydon merged commit 853ce0f into main Jul 1, 2024
8 checks passed
@spydon spydon deleted the gtk4_paned_look branch July 1, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed UI/UX
Projects
None yet
3 participants