-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
hi @TheLiux thanks for you PR I am not sure about this one honestly Testing this in this branch https://github.com/ubuntu/yaru_widgets.dart/tree/test_no_splash @Jupi007 @madsrh @d-loose @elioqoshi please test this as well when you have time |
Honestly, I have mixed feelings. 🤔 |
I think that without ripple the effect is less material-like and more yaru-like. If someone want the ripple and someone no, maybe a more effective approach would be to implement a bool that enables or disables the ripple effect, allowing users to choose whether they want it or not. |
The idea is good, but it would be useless because you can already use |
Yeah, that's fair, i didn't think that 😄 |
Sorry I am late here as I was out of office. First of all, thanks for the contribution @TheLiux ! |
Hi @elioqoshi ! Honestly, like I mentioned earlier, the ripple effect in this reminds me a lot of Material Design. If someone uses a Flutter app and compares it to a GTK app, they're bound to see some differences. Even though this package is built on top of the Flutter Material Library, I think the main aim here should be to make it look less like Material and more like Yaru. So, I understand that there will always be some differences between native apps and Flutter apps. But if you come across a noticeable difference, why not eliminate it to maintain a native feel? |
I agree with that thinking @TheLiux. We should have a conversation exactly like that and go from there with an implementation once we found a consensus. @Jupi007 @Feichtmeier can you remind me what's the reasoning behind having the ripple effect? If it's not in GTK I can understand the thinking that we might want to reevaluate that. What do you think? |
@elioqoshi material design comes from mobile, so the ink ripple can be considered as a tactile tap response. |
How about we'd keep it if yaru.dart is used in a mobile device? In common_themes there is a flag for this |
@Feichtmeier That seems reasonable to me. |
@Feichtmeier this is a good idea 👍 |
Result is already visible in https://ubuntu.github.io/yaru.dart/#/ |
* feat: added no splash factory * Update lib/src/themes/common_themes.dart * fix fail --------- Co-authored-by: Stefano Liuzzo Scorpo <stefano.liuzzo@devmy.it> Co-authored-by: Frederik Feichtmeier <frederik.feichtmeier@gmail.com>
Removed Material splash effect on widgets, to align Yaru library with Canonical Vanilla Design, this PR closes #382