Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Yaru animated ok icon improvements #58

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Yaru animated ok icon improvements #58

merged 2 commits into from
Sep 4, 2022

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Sep 4, 2022

  • late final class vars ;
  • remove useless type definition ;
  • better animation.

Before:

Capture.video.du.04-09-2022.20.38.09.webm

After:

Capture.video.du.04-09-2022.20.31.17.webm

Note: slowed down animation to clearly see the diff between them.

@Jupi007
Improvements around YaruAnimatedOkIcon
d05bd63 
- late final class vars
- remove useless type definition
- better animation
@Jupi007
Fix typo
d5aea04
Feichtmeier
Feichtmeier approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks indeed better 🐱
Maybe you can help yourself with a little bit more linting?

@Jupi007
Copy link
Member Author

Jupi007 commented Sep 4, 2022

Maybe you can help yourself with a little bit more linting?

You're right, I didn't noticed, but I don't have a analysis_options.yaml file.
I'll fix that in another PR, thanks :D

@Jupi007 Jupi007 merged commit 8f3ea3d into master Sep 4, 2022
@Jupi007 Jupi007 deleted the yaru_animated_ok_icon_improvements branch September 4, 2022 19:05
@Jupi007 Jupi007 added the Animated icons Related to the animated icons label Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

Assignees
No one assigned
Labels
Animated icons Related to the animated icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jupi007 @Feichtmeier