Not honoring text scaling factor: icons too small

[memeplex]

I've a hidpi screen but I use it with a scale factor of 1 (since 2 would be too much, the resolution is not that high) and up-scaled fonts. The icons in the appindicator extension are slightly smaller than the surrounding icons in the top bar. Changing this:

this._iconBox = new AppIndicator.IconActor(indicator, Panel.PANEL_ICON_SIZE + 6);

to

this._iconBox = new AppIndicator.IconActor(indicator, Panel.PANEL_ICON_SIZE + 12);

fixes the issue in an ugly way.

[memeplex]

I think this is due to the fact that the text has been scaled up. PANEL_ICON_SIZE is equal to 16 but other icons in the top bar are clearly larger than that (about 20 pixels). PANEL_ICON_SIZE is a constant that doesn't get updated when the font is scaled. When I change the text scaling factor every other item in the panel get resized except for the icons in the appindicator extension. You can try that by simply changing the text scaling factor from Tweaks. If you have a big font the topbar geometry and icons (except for the indicator ones) are updated to fit the font size.

Take a look at https://gitlab.gnome.org/GNOME/gnome-shell/blob/master/js/ui/panelMenu.js.
Maybe vfunc_allocate points towards a solution. Also notice the use of x_fill and y_fill.

[memeplex]

Now I'm using a 3000x2000 screen at 2x scale factor and 1x font scaling factor and, on the contrary, I had to set Panel.PANEL_ICON_SIZE + 2. This badly needs to be configurable or smarter. Configurable seems easier though.

[memeplex]

Thanks Marco!

[jarrard]

Sadly these changes did not resolve my problem, I have the icons being quite small. And with font scaling up to 1.50.

Using Pop!_OS atm.