Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide shadow #26

Closed
jpnurmi opened this issue Feb 5, 2023 · 11 comments · Fixed by #29
Closed

Wide shadow #26

jpnurmi opened this issue Feb 5, 2023 · 11 comments · Fixed by #29
Assignees

Comments

@jpnurmi
Copy link
Member

jpnurmi commented Feb 5, 2023

I've noticed that my screenshots have had super wide shadows lately. Is it coming from here?

image

@Feichtmeier
Copy link
Member

I've noticed that my screenshots have had super wide shadows lately. Is it coming from here?

image

I've noticed the same! Good question
Does it also happen if you screenshot discord? Since it's made with react native

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 5, 2023

yaru_widgets example with handy_window removed:

image

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 5, 2023

Before #22 After #22
image image

/cc @Jupi007

@Jupi007
Copy link
Member

Jupi007 commented Feb 5, 2023

It is "normal" because I copied-pasted the shadow from Libadwaita.
But, I just compared nautilus with the handy_window example, and it looks like box-shadow properties are not interpreted in the same way in Gtk3 as in Gtk4... The Libadwaita shadow is bigger than the Gtk3 one, but handy_window one is even larger.

I'll try to adjust that :)

@Jupi007 Jupi007 self-assigned this Feb 5, 2023
@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 7, 2023

@Jupi007 Did you have time to take a look? I noticed that the wide shadow is included in the minimum window size, too. Unfortunately, GDK includes shadows in the minimum window size. :(

@Jupi007
Copy link
Member

Jupi007 commented Feb 7, 2023

Oh, okay. In fact I had just started to work a little bit on :)
But I'll revert it to the original one, I think it is the best thing to do.
I didn't know that the shadow was take in account like that.

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 7, 2023

Me neither. :) I only realized it because the wide shadow made it possible to resize the software store window very small.

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 7, 2023

Is it possible to revert the shadow only but keep the colors?

@Jupi007
Copy link
Member

Jupi007 commented Feb 7, 2023

What do you mean? Which colors? 🤔

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 7, 2023

Didn't we change the colors to match libadwaita? Or did I confuse things with the YaruTitleBar colors? :D

@Jupi007
Copy link
Member

Jupi007 commented Feb 7, 2023

Oh, you mean the headerbar (I was searching something colorful 😅).
It won't be affected, nor the bright dark theme border :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants