Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimic Libadwaita window and headerbar style #22

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Jan 10, 2023

  • Remove prominent dark window border also on light theme ;
  • Adjust window box-shadow ;
  • Reduce window controls spacing ;
  • Use Libadwaita colors and size in the headerbar.
Focused Backdrop
Light Capture d’écran du 2023-01-10 18-57-59 Capture d’écran du 2023-01-10 18-58-05
Dark Capture d’écran du 2023-01-10 18-58-22 Capture d’écran du 2023-01-10 19-03-58

The backdrop headerbar should take the window background colour (it is fine in the light theme).
@Feichtmeier, we need to define which colour use to replace the current one (related to ubuntu/yaru.dart#234), so I can also use it here.

@Jupi007
Copy link
Member Author

Jupi007 commented Jan 26, 2023

@Feichtmeier What do you think of merge this as it awaiting that we decide something about the dark theme background.
In fact, there is some really interesting thing in this PR I would like to get in (like the removing of the dark border in light theme - like that we did previously in dark theme).

@Feichtmeier
Copy link
Member

yes looks nice

@Jupi007 Jupi007 marked this pull request as ready for review January 26, 2023 11:03
@Jupi007
Copy link
Member Author

Jupi007 commented Jan 26, 2023

Okay, let's merge so

@Jupi007 Jupi007 merged commit b7e5a18 into ubuntu:main Jan 26, 2023
@Jupi007 Jupi007 deleted the mimic-libadwaita branch January 26, 2023 11:04
@jpnurmi jpnurmi mentioned this pull request Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants