Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing stage packages and copy ibus socket files to enable ibus for GTK3 applications out-of-the-box. #104

Merged
merged 2 commits into from Mar 29, 2018
Merged

Add missing stage packages and copy ibus socket files to enable ibus for GTK3 applications out-of-the-box. #104

merged 2 commits into from Mar 29, 2018

Conversation

oSoMoN
Copy link
Member

@oSoMoN oSoMoN commented Mar 29, 2018

No description provided.

@seb128
Copy link
Contributor

seb128 commented Mar 29, 2018

Would it make sense to symlink rather than copy? Unsure if the bus address can change in case of restart of the daemon (segfault, config change, ...)

Create a symlink to the socket path instead of copying the socket fil…
5a0be4e 
…es, in case the bus address changes in a session.
kenvandine
kenvandine approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for digging into this.

@kenvandine kenvandine merged commit 341da42 into ubuntu:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenvandine kenvandine kenvandine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oSoMoN @seb128 @kenvandine