Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop-exports: ensure we have $HOME/.config dir #138

Merged
merged 2 commits into from Sep 4, 2018

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Jul 3, 2018

Create it if it doesn't exist, otherwise next operations will fail

I was just running a snap, while I noticed:

marco@tricky:/data/telegram-snap (master):✓ $ mailspring 
/snap/mailspring/216/bin/desktop-launch: line 177: /home/marco/snap/mailspring/common/.config/user-dirs.dirs: No such file or directory
cp: cannot create regular file '/home/marco/snap/mailspring/common/.config/': Not a directory
/snap/mailspring/216/bin/desktop-launch: line 180: /home/marco/snap/mailspring/common/.config/user-dirs.dirs.md5sum: No such file or directory
/snap/mailspring/216/bin/desktop-launch: line 180: /home/marco/snap/mailspring/common/.config/user-dirs.locale.md5sum: No such file or directory

Create it if it doesn't exist, otherwise next operations will fail
Copy link
Member

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@oSoMoN
Copy link
Member

oSoMoN commented Sep 3, 2018

The test looks superfluous, given that "mkdir -p" will silently do nothing if the directory already exists.

@3v1n0
Copy link
Contributor Author

3v1n0 commented Sep 4, 2018

@oSoMoN yeah, not really harmful though... I get rid of it if you prefer.

@oSoMoN
Copy link
Member

oSoMoN commented Sep 4, 2018

LGTM, thanks!

@oSoMoN oSoMoN merged commit d774411 into ubuntu:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants