Visual Studio Code fix #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the permalinks for both 32 and 64 bits platform * Bring back with BaseInstaller download support to minimize the number of override * Change icon to point to code.png instead of vscode.png Closes: #247
medium tests work added new mock server and links
Fix for the new link
Fix for the new link Closes: #247
|
@LyzardKing: This looks good to me, however, you can remove test_install_with_changed_license_page() altogether as this is tested on the base framework case and we didn't override anything from it. Did you run the medium and large tests for this part of code? |
|
Yes. The tests are working... I'll remove the changed license parge. |
|
Looks perfect! Let's merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR on our VSC fixes