Android-ndk fix #266
Android-ndk fix #266
Conversation
|
I also added clang as a dependency, since it is now the supported compiler. |
| @@ -54,7 +54,7 @@ class AndroidNDKContainer(ContainerTests, test_android.AndroidNDKTests): | |||
|
|
|||
| def setUp(self): | |||
| self.hosts = {443: ["developer.android.com"]} | |||
| self.apt_repo_override_path = os.path.join(self.APT_FAKE_REPO_PATH, 'android') | |||
| self.apt_repo_override_path = os.path.join(self.APT_FAKE_REPO_PATH, 'android-ndk') | |||
There was a problem hiding this comment.
I don't see you creating a separate android-ndk repository for medium tests but you did change that path, did you get the medium tests working with this change? Was there already a separate repository that I don't see? :)
|
And here is a review! Just a comment on the medium repository "android-ndk" that you now reference. I'm quite surprised this works for you or maybe you forgot to include in the commits a "docker/create_packages.sh" changes? Other than that, I did test it and it's good. |
|
Yes, I forgot about the docker/create_packages.sh file. |
|
yeah, let's follow upstream's practices. |
|
I noticed that the zipfile is in another directory on the google server. |
zipfile now in dl.google.com medium test works
|
Perfect! I'm merging this :) Once the other is merged as well, can you just sum up what tests are passing and not passing for you? I must say I'm a little bit lost in the email threads :) (I know that you can't run the tests in the vm due to python2 exceptions) |
This reflects the changes made on the download page for the android ndk.
The download is now a zipfile, only for 64 bit arch.
The checksum now is sha1 instead of md5.
The large test works on my system.
The medium tests are fixed.
Since I know nothing about the ndk, I'm not sure what to test.
At the moment the only check is the existence of the main executable, as described on the webpage.
If there is something better that needs to be tested please let me know.
Fixes #265