fix: give cnf data a measurement tag #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersson1234
force-pushed
the
fix_cnf_collector
branch
2 times, most recently
from
b724121
to
c57bdfb
Compare
murraybd
requested changes
Sep 12, 2023
| "measurement": "command_not_found_age", | ||
| "fields": { | ||
| "cnf_age": count, | ||
| "out_of_date": ((count > 1) if count is not None else True), |
There was a problem hiding this comment.
Setting out_of_date to True when there may have been a networking issue (HTTPError) feels incorrect to me. Additionally, if there is an HTTPError I think we should skip returning any data for that release series rather than writing what is effectively nothing to the database.
There was a problem hiding this comment.
Amended in the latest diff :)
andersson1234
force-pushed
the
fix_cnf_collector
branch
from
c57bdfb
to
30b02d6
Compare
andersson1234
force-pushed
the
fix_cnf_collector
branch
from
30b02d6
to
8e61746
Compare
murraybd
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.