Improve togglable contrast (#404)

ubuntu · Nov 20, 2022 · 154e6f0 · 154e6f0
1 parent 7f59250
commit 154e6f0
Show file tree

Hide file tree

Showing 39 changed files with 2 additions and 2 deletions.
diff --git a/lib/src/controls/yaru_togglable.dart b/lib/src/controls/yaru_togglable.dart
@@ -233,8 +233,8 @@ abstract class YaruTogglableState<S extends YaruTogglable> extends State<S>
     final colorScheme = Theme.of(context).colorScheme;
 
     // Normal colors
-    const uncheckedColor = Colors.transparent;
-    final uncheckedBorderColor = colorScheme.onSurface.withOpacity(.25);
+    final uncheckedColor = colorScheme.surface;
+    final uncheckedBorderColor = colorScheme.onSurface.withOpacity(.3);
     final checkedColor = colorScheme.primary;
     final checkmarkColor = colorScheme.onPrimary;
 

diff --git a/test/controls/goldens/yaru_check_button-unchecked-dark.png b/test/controls/goldens/yaru_check_button-unchecked-dark.png
diff --git a/test/controls/goldens/yaru_check_button-unchecked-light.png b/test/controls/goldens/yaru_check_button-unchecked-light.png
diff --git a/test/controls/goldens/yaru_check_button-unckecked-focused-dark.png b/test/controls/goldens/yaru_check_button-unckecked-focused-dark.png
diff --git a/test/controls/goldens/yaru_check_button-unckecked-focused-light.png b/test/controls/goldens/yaru_check_button-unckecked-focused-light.png
diff --git a/test/controls/goldens/yaru_check_button-unckecked-hovered-dark.png b/test/controls/goldens/yaru_check_button-unckecked-hovered-dark.png
diff --git a/test/controls/goldens/yaru_check_button-unckecked-hovered-light.png b/test/controls/goldens/yaru_check_button-unckecked-hovered-light.png
diff --git a/test/controls/goldens/yaru_check_button-unckecked-pressed-dark.png b/test/controls/goldens/yaru_check_button-unckecked-pressed-dark.png
diff --git a/test/controls/goldens/yaru_check_button-unckecked-pressed-light.png b/test/controls/goldens/yaru_check_button-unckecked-pressed-light.png
diff --git a/test/controls/goldens/yaru_checkbox-unchecked-dark.png b/test/controls/goldens/yaru_checkbox-unchecked-dark.png
diff --git a/test/controls/goldens/yaru_checkbox-unchecked-light.png b/test/controls/goldens/yaru_checkbox-unchecked-light.png
diff --git a/test/controls/goldens/yaru_checkbox-unckecked-focused-dark.png b/test/controls/goldens/yaru_checkbox-unckecked-focused-dark.png
diff --git a/test/controls/goldens/yaru_checkbox-unckecked-focused-light.png b/test/controls/goldens/yaru_checkbox-unckecked-focused-light.png
diff --git a/test/controls/goldens/yaru_checkbox-unckecked-hovered-dark.png b/test/controls/goldens/yaru_checkbox-unckecked-hovered-dark.png
diff --git a/test/controls/goldens/yaru_checkbox-unckecked-hovered-light.png b/test/controls/goldens/yaru_checkbox-unckecked-hovered-light.png
diff --git a/test/controls/goldens/yaru_checkbox-unckecked-pressed-dark.png b/test/controls/goldens/yaru_checkbox-unckecked-pressed-dark.png
diff --git a/test/controls/goldens/yaru_checkbox-unckecked-pressed-light.png b/test/controls/goldens/yaru_checkbox-unckecked-pressed-light.png
diff --git a/test/controls/goldens/yaru_popup_menu_item-unchecked-dark.png b/test/controls/goldens/yaru_popup_menu_item-unchecked-dark.png
diff --git a/test/controls/goldens/yaru_popup_menu_item-unchecked-hovered-dark.png b/test/controls/goldens/yaru_popup_menu_item-unchecked-hovered-dark.png
diff --git a/test/controls/goldens/yaru_popup_menu_item-unchecked-hovered-light.png b/test/controls/goldens/yaru_popup_menu_item-unchecked-hovered-light.png
diff --git a/test/controls/goldens/yaru_popup_menu_item-unchecked-light.png b/test/controls/goldens/yaru_popup_menu_item-unchecked-light.png
diff --git a/test/controls/goldens/yaru_popup_menu_item-unchecked-pressed-dark.png b/test/controls/goldens/yaru_popup_menu_item-unchecked-pressed-dark.png
diff --git a/test/controls/goldens/yaru_popup_menu_item-unchecked-pressed-light.png b/test/controls/goldens/yaru_popup_menu_item-unchecked-pressed-light.png
diff --git a/test/controls/goldens/yaru_radio-unchecked-dark.png b/test/controls/goldens/yaru_radio-unchecked-dark.png
diff --git a/test/controls/goldens/yaru_radio-unchecked-light.png b/test/controls/goldens/yaru_radio-unchecked-light.png
diff --git a/test/controls/goldens/yaru_radio-unckecked-focused-dark.png b/test/controls/goldens/yaru_radio-unckecked-focused-dark.png
diff --git a/test/controls/goldens/yaru_radio-unckecked-focused-light.png b/test/controls/goldens/yaru_radio-unckecked-focused-light.png
diff --git a/test/controls/goldens/yaru_radio-unckecked-hovered-dark.png b/test/controls/goldens/yaru_radio-unckecked-hovered-dark.png
diff --git a/test/controls/goldens/yaru_radio-unckecked-hovered-light.png b/test/controls/goldens/yaru_radio-unckecked-hovered-light.png
diff --git a/test/controls/goldens/yaru_radio-unckecked-pressed-dark.png b/test/controls/goldens/yaru_radio-unckecked-pressed-dark.png
diff --git a/test/controls/goldens/yaru_radio-unckecked-pressed-light.png b/test/controls/goldens/yaru_radio-unckecked-pressed-light.png
diff --git a/test/controls/goldens/yaru_radio_button-unchecked-dark.png b/test/controls/goldens/yaru_radio_button-unchecked-dark.png
diff --git a/test/controls/goldens/yaru_radio_button-unchecked-light.png b/test/controls/goldens/yaru_radio_button-unchecked-light.png
diff --git a/test/controls/goldens/yaru_radio_button-unckecked-focused-dark.png b/test/controls/goldens/yaru_radio_button-unckecked-focused-dark.png
diff --git a/test/controls/goldens/yaru_radio_button-unckecked-focused-light.png b/test/controls/goldens/yaru_radio_button-unckecked-focused-light.png
diff --git a/test/controls/goldens/yaru_radio_button-unckecked-hovered-dark.png b/test/controls/goldens/yaru_radio_button-unckecked-hovered-dark.png
diff --git a/test/controls/goldens/yaru_radio_button-unckecked-hovered-light.png b/test/controls/goldens/yaru_radio_button-unckecked-hovered-light.png
diff --git a/test/controls/goldens/yaru_radio_button-unckecked-pressed-dark.png b/test/controls/goldens/yaru_radio_button-unckecked-pressed-dark.png
diff --git a/test/controls/goldens/yaru_radio_button-unckecked-pressed-light.png b/test/controls/goldens/yaru_radio_button-unckecked-pressed-light.png