Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge yaru.dart and yaru_icons.dart into this repository #835

Closed
6 tasks done
Feichtmeier opened this issue Feb 22, 2024 · 4 comments
Closed
6 tasks done

Merge yaru.dart and yaru_icons.dart into this repository #835

Feichtmeier opened this issue Feb 22, 2024 · 4 comments

Comments

@Feichtmeier
Copy link
Member

Feichtmeier commented Feb 22, 2024

As discussed on discord we want to merge yaru.dart theme and yaru_icons.dart into this repository to avoid the unnecessary maintenance overhead of managing those three depedencies, especially because yaru_widgets has deps to yaru.dart and yaru_icons.dart but also because all of the community and canonical apps use those three libs always together, and never alone.

The plan:

  • copy the source code of the icons and the theme to the yaru_widgets.dart repo
  • rename yaru.dart and yaru_icons.dart to xx_archive.dart and set them to the archive mode
  • then rename yaru_widgets.dart in the repo and pubspec to yaru.dart
  • Make the icon page work in the github pages web page build! #857
  • make a new 4.0.0 release when everything really works
  • Help the canonicals migrating their apps, as it is an easy yet big diff to make
    CC @d-loose @spydon
@spydon
Copy link
Collaborator

spydon commented Mar 3, 2024

I can migrate the Canonical repos, as long as none of them are pinned on a previous version, which I know some have been previously.

@Feichtmeier
Copy link
Member Author

Feichtmeier commented Mar 5, 2024

Important

yaru.dart 4.0.0 is now released

Information for canonical flutter contributors on what to do:

  • remove yaru_icons and yaru_widgets from pubspec
  • replace all imports of yaru_icons.dart and yaru_widgets.dart with just yaru.dart
  • in case you were using YaruAnimatedIcon somewhere, the api has changed:
    grafik

Here is the diff of this in musicpod as an example:
https://github.com/ubuntu-flutter-community/musicpod/pull/542/files

Was really straight forward
CC @spydon @d-loose @robert-ancell @BLKKKBVSIK

@Feichtmeier
Copy link
Member Author

@spydon I think we are done here, or?

@spydon
Copy link
Collaborator

spydon commented Mar 20, 2024

@spydon I think we are done here, or?

Probably!

@Feichtmeier Feichtmeier unpinned this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants