chore!: migrate yaru.dart and yaru_icons.dart into yaru_widgets #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that yaru_colors.dart has the Ubuntu Butterfly Pink, we can have the variant in yaru.dart
Example: improve variant selector and show all
* Add source code </> icon Fixes #78 * Better icon
* Text inputs: change cursor color to onSurface * Change inputs icon color to onSurface
* Rename toggle-button folder into toogle - Checkbox-button -> checkbox - Radio-button -> radio - Switch-button -> switch * Rename arrow icons - Arrow-*-simple -> arrow - Arrow -> arrow-filled * Rename audio -> music_note * Rename addon -> puzzle_piece * Rename arrow -> arrow-outlined * Optimize bettery naming - Battery-10 -> battery-full - Divide by 10 battery level - Remove level prefix * Simplify weather icon names Add new showers icon * Symlink online-accounts to could * Rename edit-*icons * Add folder-new icon * Improve media and text icon names * Optimize object icon names * Optimize object icon names * Sync printer-network with folder-network * Radio -> radiobox * Optimize speaker icon names * Revert example.dart * Optimize fullscreen icon names * Better computer-legacy icon * Simplify all other icon names * Add screen icon * Improve a few last icon names * Remove new icons (for next PR) * Fix battery empty name * Build font * Update example
* Add binding enum of freedesktop compliant icon names Fixes #104 * Add shortcut to all icons
* YaruTheme widget: build empty during accent color initialiation Fixes: #231 * Use mocked GSettings in all widget tests
Bildschirmaufnahme_2024-02-23_um_14.14.07.movThe goldens pass locally after clean/upgrade and regeneration |
Jupi007
requested changes
Feb 24, 2024
There was a problem hiding this comment.
I think we can improve and simplify some files placements:
colors.dartcould be moved to thefoundation/folder ;icons_foundation/could be merged withfoundation;text/font/should be moved toassets/, andtext/text_theme.darttothemes/;icons_widgets/towidgets;- and I'm not sure, but
theme_widgets/inherited_theme.dartcan maybe be moved towidgets/(orthemes/) ?
Except that, this looks great. I didn't noticed any problem with icons :D
I kept the sub structure for this PR to make a first atempt where everything works. Maybe I could do this in a second PR? then I change from Fix to Ref in the PR desc |
Ofc, sounds good 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
This migrates yaru.dart and yaru_icons.dart into this repository, but all commits are kept 🤞
To merge this we need to check very precicly if everything is correctly merged
TODO
Ref #835