Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide control buttons when first/last page reached #209

Merged
merged 1 commit into from Sep 20, 2022
Merged

Hide control buttons when first/last page reached #209

merged 1 commit into from Sep 20, 2022

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Sep 20, 2022 •
edited

Capture.video.du.20-09-2022.10.27.41.webm

Closes #208

Feichtmeier
Feichtmeier approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jupi007
Copy link
Member Author

Jupi007 commented Sep 20, 2022

About the infinite scroll, the PageView doesn't allow it.
And it require this kind of trick: https://github.com/jzoom/infinity_page_view/blob/master/package/lib/infinity_page_view.dart

@madsrh
Copy link
Member

madsrh commented Sep 20, 2022

👌 looks good @Jupi007

@Jupi007 Jupi007 merged commit 5825bba into main Sep 20, 2022
@Jupi007 Jupi007 deleted the Jupi007/issue208 branch September 20, 2022 09:08
Feichtmeier added a commit that referenced this pull request Sep 21, 2022
@Feichtmeier
Release 1.1.4
0f58364 
- [Frederik Feichtmeier](https://github.com/Feichtmeier)
  - YaruCompactLayout: simplify and remove appbar mode (#212)
  - WideLayout: add yaru transition (#210)
- [J-P Nurmi](https://github.com/jpnurmi)
  - Fix version constraints (#207)
- [Paul Kepinski](https://github.com/Jupi007)
  - Hide control buttons when first/last page reached (#209)
@Feichtmeier Feichtmeier mentioned this pull request Sep 21, 2022
Merged
Feichtmeier added a commit that referenced this pull request Sep 21, 2022
@Feichtmeier
Release 1.1.4 (#213)
999193d 
- [Frederik Feichtmeier](https://github.com/Feichtmeier)
  - YaruCompactLayout: simplify and remove appbar mode (#212)
  - WideLayout: add yaru transition (#210)
- [J-P Nurmi](https://github.com/jpnurmi)
  - Fix version constraints (#207)
- [Paul Kepinski](https://github.com/Jupi007)
  - Hide control buttons when first/last page reached (#209)
Feichtmeier added a commit that referenced this pull request Feb 22, 2024
@Feichtmeier
Release 0.4.0 (#209)
2a503ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

@madsrh madsrh Awaiting requested review from madsrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement for arrows on image carousel
3 participants
@Jupi007 @madsrh @Feichtmeier