Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Yaru(Round)IconButton as IconButton #219

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Implement Yaru(Round)IconButton as IconButton #219

merged 1 commit into from
Sep 23, 2022

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Sep 23, 2022

With IconButton we get accessibility support, icon theming, focus management, mouse cursor, ... for free.

@jpnurmi
Copy link
Member Author

jpnurmi commented Sep 23, 2022

It ensures the same 40x40 size by default but can be now styled to have any dimensions. It has the same API as IconButton (except the old color properties that are now available in the style) which is why the proposal to name it YaruIconButton.

@Feichtmeier
Copy link
Member

Sounds good. The only reason why I've used the custom inkwell was because the icon buttons get stretched all the time. If this isn't the case anymore I'm fine with this

@Feichtmeier Feichtmeier merged commit 126165c into ubuntu:main Sep 23, 2022
@jpnurmi jpnurmi deleted the icon-button branch September 23, 2022 16:07
@Feichtmeier Feichtmeier mentioned this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants