Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YaruPopupMenuButton #310

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add YaruPopupMenuButton #310

merged 1 commit into from
Oct 20, 2022

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Oct 20, 2022 •
edited

grafik
grafik

@Feichtmeier Feichtmeier merged commit 2d73df2 into main Oct 20, 2022
@Feichtmeier Feichtmeier deleted the popup branch October 20, 2022 14:15
jpnurmi
jpnurmi reviewed Oct 20, 2022
View reviewed changes
lib/src/controls/yaru_popup_menu_button.dart
}
}

class YaruPopupDecoration extends StatelessWidget {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be private to avoid internal implementation details in the yaru.dart import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Will do a refine of this pr with your requests
Thanks for the review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#311

lib/src/controls/yaru_popup_menu_button.dart
onCanceled: onCanceled,
tooltip: tooltip,
itemBuilder: (context) {
return items;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we keep it as a builder? one can easily do it like this in an app, but it would be nice to have the opportunity to lazily build the items in their appropriate states at the time the button is pressed. if it's not a builder, you need to build the items in advance and rebuild the button whenever any popup item would change even when there's no popup, which is most of the time. :)

@Feichtmeier Feichtmeier mentioned this pull request Nov 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Feichtmeier @jpnurmi