YaruCheckedPopupMenuItem: add golden test

lib/src/controls/yaru_popup_menu_button.dart

@@ -2,6 +2,8 @@ import 'package:flutter/material.dart';
 import 'package:yaru_icons/yaru_icons.dart';
 import '../constants.dart';
 
+const _kYaruCheckMarkSize = 18.0;
+
 /// A generic wrapper around [PopupMenuButton] that is visually more consistent
 /// to buttons and dialogs than [DropdownButton]
 class YaruPopupMenuButton<T> extends StatelessWidget {
@@ -134,7 +136,7 @@ class _YaruCheckedPopupMenuItemState<T>
   Widget buildChild() {
     return IgnorePointer(
       child: ListTile(
-        minLeadingWidth: 18,
+        minLeadingWidth: _kYaruCheckMarkSize,
         enabled: widget.enabled,
         leading: _YaruCheckMark(
           checked: widget.checked,
@@ -159,39 +161,44 @@ class _YaruCheckMark extends StatelessWidget {
     final borderColor = Theme.of(context).colorScheme.onSurface.withOpacity(
           Theme.of(context).brightness == Brightness.light ? 0.4 : 1,
         );
-    const size = 18.0;
     const duration = 200;
-    return checked
-        ? AnimatedContainer(
-            height: size,
-            width: size,
-            duration: const Duration(
-              milliseconds: duration,
-            ),
-            decoration: BoxDecoration(
-              color: Theme.of(context).primaryColor,
-              borderRadius: BorderRadius.circular(4),
-            ),
-            child: const Icon(
-              Icons.check,
-              color: Colors.white,
-              size: size,
-            ),
-          )
-        : AnimatedContainer(
-            height: size,
-            width: size,
-            duration: const Duration(
-              milliseconds: duration,
-            ),
-            decoration: BoxDecoration(
-              border: Border.all(
-                color: borderColor,
-                width: 2,
+    return SizedBox(
+      width: _kYaruCheckMarkSize,
+      height: double.infinity,
+      child: Center(
+        child: checked
+            ? AnimatedContainer(
+                height: _kYaruCheckMarkSize,
+                width: _kYaruCheckMarkSize,
+                duration: const Duration(
+                  milliseconds: duration,
+                ),
+                decoration: BoxDecoration(
+                  color: Theme.of(context).primaryColor,
+                  borderRadius: BorderRadius.circular(4),
+                ),
+                child: const Icon(
+                  Icons.check,
+                  color: Colors.white,
+                  size: _kYaruCheckMarkSize,
+                ),
+              )
+            : AnimatedContainer(
+                height: _kYaruCheckMarkSize,
+                width: _kYaruCheckMarkSize,
+                duration: const Duration(
+                  milliseconds: duration,
+                ),
+                decoration: BoxDecoration(
+                  border: Border.all(
+                    color: borderColor,
+                    width: 2,
+                  ),
+                  borderRadius: BorderRadius.circular(4),
+                ),
               ),
-              borderRadius: BorderRadius.circular(4),
-            ),
-          );
+      ),
+    );
   }
 }
 
@@ -242,7 +249,7 @@ class _YaruMultiSelectPopupMenuItemState<T>
   Widget buildChild() {
     return IgnorePointer(
       child: ListTile(
-        minLeadingWidth: 18,
+        minLeadingWidth: _kYaruCheckMarkSize,
         enabled: widget.enabled,
         leading: _YaruCheckMark(checked: _checked),
         title: widget.child,

test/controls/yaru_popup_menu_item_test.dart

@@ -0,0 +1,71 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:yaru_widgets/yaru_widgets.dart';
+
+import '../yaru_golden_tester.dart';
+
+void main() {
+  testWidgets(
+    'golden images',
+    (tester) async {
+      final variant = goldenVariant.currentValue!;
+
+      await tester.pumpScaffold(
+        YaruPopupMenuButton(
+          child: const Text('Button'),
+          itemBuilder: (context) => [
+            for (var i = 0; i < 3; ++i)
+              YaruCheckedPopupMenuItem(
+                child: Text('YaruPopupMenuItem $i'),
+                checked: variant.hasState(MaterialState.selected),
+                enabled: !variant.hasState(MaterialState.disabled),
+              ),
+          ],
+        ),
+        themeMode: variant.themeMode,
+        size: const Size(300, 200),
+      );
+      await tester.pumpAndSettle();
+
+      await tester.tap(find.byType(YaruPopupMenuButton));
+      await tester.pumpAndSettle();
+
+      if (variant.hasState(MaterialState.pressed)) {
+        await tester.down(find.text('YaruPopupMenuItem 0'));
+        await tester.pumpAndSettle();
+      } else if (variant.hasState(MaterialState.hovered)) {
+        await tester.hover(find.text('YaruPopupMenuItem 0'));
+        await tester.pumpAndSettle();
+      }
+
+      await expectLater(
+        find.byType(MaterialApp),
+        matchesGoldenFile(
+          'goldens/yaru_popup_menu_item-${variant.label}.png',
+        ),
+      );
+    },
+    variant: goldenVariant,
+    tags: 'golden',
+  );
+}
+
+final goldenVariant = ValueVariant({
+  ...goldenThemeVariants('unchecked', <MaterialState>{}),
+  ...goldenThemeVariants('unchecked-disabled', {MaterialState.disabled}),
+  ...goldenThemeVariants('unchecked-hovered', {MaterialState.hovered}),
+  ...goldenThemeVariants('unchecked-pressed', {MaterialState.pressed}),
+  ...goldenThemeVariants('checked', {MaterialState.selected}),
+  ...goldenThemeVariants('checked-disabled', {
+    MaterialState.selected,
+    MaterialState.disabled,
+  }),
+  ...goldenThemeVariants('checked-hovered', {
+    MaterialState.selected,
+    MaterialState.hovered,
+  }),
+  ...goldenThemeVariants('checked-pressed', {
+    MaterialState.selected,
+    MaterialState.pressed,
+  }),
+});

test/yaru_golden_tester.dart

@@ -19,6 +19,7 @@ extension YaruGoldenTester on WidgetTester {
         themeMode: themeMode,
         theme: theme ?? yaruLight,
         darkTheme: darkTheme ?? yaruDark,
+        debugShowCheckedModeBanner: false,
         home: Scaffold(
           body: Center(child: widget),
         ),