Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #338

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Update PR template #338

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2263ac7
Update PR template
jpnurmi Oct 23, 2022
8502352
Emphasize with "either"
jpnurmi Oct 24, 2022
2c2f2d6
Fix table
jpnurmi Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
## Pull request checklist

- [ ] I added a before/after/light/dark table if the changes I made could change the components look
- [ ] Either this PR does not introduce visual changes, or
- [ ] I run `flutter test --update-goldens` and committed the changes if there were any, or
- [ ] I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.

<!-- Remove this if your change does not touch components -->
<!--
| |Before|After|
|-|-|-|
|Light| | |
|Dark| | |
|Dark| | |

-->