Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YaruBanner: clean up unused internal mouse cursor property #427

Merged
merged 1 commit into from Nov 29, 2022
Merged

YaruBanner: clean up unused internal mouse cursor property #427

merged 1 commit into from Nov 29, 2022

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Nov 29, 2022

The click mouse cursor is provided by the InkWell above the card.

Pull request checklist

  • This PR does not introduce visual changes, or
    • I ran flutter test --update-goldens and committed the changes if there were any, or
    • I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.
      Before After
      Light
      Dark

The click mouse cursor is provided by the InkWell above the card.
@Feichtmeier
Copy link
Member

ah I am not sure about this one
The reason why I added this was because the cursor changes depending on where you are in the banner if you do not use this mouse cursor around it

@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 29, 2022

It's unused - _Banner does not use its mouseCursor for anything or pass it anywhere.

@Feichtmeier
Copy link
Member

aaah 👴 I know what happened. Previously it was using a ListTile which itself has an ontap, which was not used :D
Good good! merging

@Feichtmeier Feichtmeier merged commit ad58bd2 into ubuntu:main Nov 29, 2022
@jpnurmi jpnurmi deleted the yaru-banner-mouse-cursor branch November 29, 2022 22:02
@jpnurmi jpnurmi mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants