YaruBanner: remove effectively unused copyIconAsWatermark #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found occurrences of two `copyIconAsWatermark`. One in the example and one in the software app. Both of them pass `watermarkIcon` so just check if `watermarkIcon != null`. One can pass the same widget to both properties should they want to "copy" it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's one occurrence of
copyIconAsWatermarkin theyaru_widgets.dartexample, and another in the software app. Both of them passwatermarkIconso neither is actually "copying" the leading icon as a watermark. This PR is a proposal to make the API more intuitive and just check ifwatermarkIcon != null. One can pass the same widget to both properties if that's desired.Pull request checklist
flutter test --update-goldensand committed the changes if there were any, or