Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract YaruWatermark from YaruBanner #430

Merged
merged 1 commit into from Nov 30, 2022
Merged

Extract YaruWatermark from YaruBanner #430

merged 1 commit into from Nov 30, 2022

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Nov 29, 2022

Before:

YaruBanner(
  watermarkIcon: ...
  ...
),

After:

YaruWatermark(
  watermark: ...
  child: YaruBannerOrAnythingElse(
    ...
  ),
),

Screenshot from 2022-11-29 23-01-16

@Feichtmeier
Copy link
Member

? why?

@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 29, 2022

After this, we'd be only a few steps away from

YaruBanner(
  child: YaruTile(
    ...
  ),
)

vs.

YaruBanner(
  child: Column(
    children: [
      Icon(...),
      Text(...),
    ]
  ),
)

@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 29, 2022

Frankly speaking, the watermark feature feels a bit store-centric but perhaps there will be other use cases? With this, you can at least control the positioning and translucency. 😉

@Feichtmeier
Copy link
Member

Ironically it is currently not used in the store, but I could imagine it can be useful anywhere. Generally it is nice to have a brouder set of components to chose from . If it helps you with the workshop app we can merge this, but generally it is always this configuration vs convient question :P

Are you sure the stack always has the same size as the child you add to watermark?

@Feichtmeier Feichtmeier merged commit 14b03e5 into ubuntu:main Nov 30, 2022
@jpnurmi jpnurmi deleted the yaru-watermark branch November 30, 2022 09:14
@jpnurmi jpnurmi mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants