Reduce repetitive Theme.of() calls #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not an expensive call, but not free either. Every
Theme.of()
call implies aLocalizations.of()
call, so two inherited widget lookups both of which are basically hashmap lookups. Last but not least, the two are merged and cached, resulting in a third hashmap lookup. Therefore it's nice to store the theme data to a variable at the beginning ofbuild()
to avoid repeating the hashmap lookups several times.https://github.com/flutter/flutter/blob/5c97543027f62bf73062db5e06b1b1b9d5636dd1/packages/flutter/lib/src/material/theme.dart#L107-L113