Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YaruTitleBar: make themable and use window controls #464

Merged
merged 1 commit into from Jan 3, 2023
Merged

YaruTitleBar: make themable and use window controls #464

merged 1 commit into from Jan 3, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 1, 2023

Visual changes extracted from #455, leaving out any actual top-level window-related functionality i.e. YaruWindowTitleBar, YaruDialogTitleBar, and YaruWindowController.

NOTE: This is a breaking change. YaruTitleBar no longer creates a YaruCloseButton that calls Navigator.pop. Instead, it has a set of properties that can be used to manage which YaruWindowControls to create.

P.S. YaruWindowTitleBar and YaruDialogTitleBar are still coming but without window_manager dependency as originally proposed in #455. :)

Changes extracted from #455, leaving out YaruWindow/DialogTitleBar etc.
@Feichtmeier
Copy link
Member

Cool, could you add some .close() constructor that adds a close button by default?

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 3, 2023

There's a separate YaruDialogTitleBar in the works that will call Navigator.pop out of the box. With the "plain" YaruTitleBar you can do:

YaruTitleBar(
  isClosable: true,
  onClose: Navigator.of(context).pop,
)

@Feichtmeier Feichtmeier merged commit 8cfb53c into ubuntu:main Jan 3, 2023
@jpnurmi jpnurmi deleted the title-bar-2 branch January 3, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants