Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: update yaru and handy_window #470

Merged
merged 2 commits into from Jan 9, 2023
Merged

Example: update yaru and handy_window #470

merged 2 commits into from Jan 9, 2023

Conversation

Feichtmeier
Copy link
Member

Pull request checklist

  • This PR does not introduce visual changes, or
    • I ran flutter test --update-goldens and committed the changes if there were any, or
    • I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.
      Before After
      Light
      Dark

@jpnurmi
Copy link
Member

jpnurmi commented Jan 9, 2023

Rebase should help ;)

jpnurmi
jpnurmi approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit 546ebe3 into main Jan 9, 2023
@jpnurmi jpnurmi mentioned this pull request Jan 10, 2023
Closed
@Jupi007 Jupi007 deleted the update_example_deps branch January 11, 2023 10:29
This was referenced Jan 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Feichtmeier @jpnurmi